-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format Library: Refactor inline link component to use React hooks #19487
Conversation
See also: #19488, which is currently set to merge to this branch. |
Looks like this will conflict with #19462. Any preference on what to merge first? |
Ah, it looks like that PR is also rewriting the component with hooks. |
Oof 😄 (cc @youknowriad, I haven't looked closely enough to have a good sense on how to proceed) |
I think it's probably not worth continuing with this if the plan is to use |
Related: #19440
This pull request seeks to refactor the inline link UI component (used for adding, viewing, and editing links in a RichText field) as a function component. Originally this was planned as a blocking change to allow for the implementation of additional custom React hooks to be used in this component as a resolution of #18755. This is planned to be addressed separately, and may ultimately not use hooks.
The changes here are intended to be a one-to-one port of the existing component, with the exception of the revisions mentioned at #19440 (comment). I may plan to extract this (6523f57) as a separate pull request in order to simplify review.
Testing Instructions:
Verify there are no regressions in viewing, adding, editing, or removing a link.