Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RangeControl component to Storybook #18146

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Add RangeControl component to Storybook #18146

merged 1 commit into from
Oct 30, 2019

Conversation

brentswisher
Copy link
Contributor

@brentswisher brentswisher commented Oct 28, 2019 •
edited
Loading

Description

Add RangeControl component to Storybook as part of #17973.
Added with the following "stories":

  • Default
  • With Help Text
  • With Min/Max Limits
  • With Icon Before
  • With Icon After
  • With Reset Button

How has this been tested?

run npm run design-system:dev
Browse to the local Storybook instance
See Range Control component is rendered with various options when selected in left-hand navigation

Types of changes

New feature (non-breaking change which adds functionality)

@ItsJonQ ItsJonQ mentioned this pull request Oct 28, 2019
Closed
8 tasks
@brentswisher brentswisher changed the title Add RangeControl component to Storyboard Add RangeControl component to Storybook Oct 28, 2019
@gziolo gziolo added [Feature] UI Components Impacts or related to the UI component system Storybook Storybook and its stories for components Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Oct 29, 2019
jorgefilipecosta
jorgefilipecosta approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor suggestions but other than that the PR looks good to me 👍

packages/components/src/range-control/stories/index.js Outdated Show resolved Hide resolved
packages/components/src/range-control/stories/index.js Outdated Show resolved Hide resolved
@brentswisher brentswisher force-pushed the add/range-control-stories branch from 07e4563 to d4853ad Compare October 30, 2019 03:12
gziolo
gziolo approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I left 2 nits but this can be a follow-up if you feel like it's something that makes sense. I'm 🚢

@gziolo gziolo merged commit cd9a4cc into master Oct 30, 2019
@gziolo gziolo deleted the add/range-control-stories branch October 30, 2019 15:07
@brentswisher brentswisher mentioned this pull request Oct 30, 2019
Merged
@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Feature] UI Components Impacts or related to the UI component system Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code Storybook Storybook and its stories for components
Projects
None yet
Milestone
Gutenberg 6.9
Development

Successfully merging this pull request may close these issues.
4 participants
@brentswisher @gziolo @jorgefilipecosta @youknowriad