-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move DatePicker and TimePicker to own Component #18087
Conversation
Maybe I should have mentioned it, but there's a problem when you first download the repository, install, and run |
@gziolo can this be labeled with hacktoberfest? |
I asked in #core-editor channel on WordPress Slack: I would recommend splitting this PR at least into two parts:
This PR is big enough. @mkaz does it make sense? I don't know exactly what did you envision with the original issue. |
Just breaking it up so it isn't one directory exporting 3 different component. It currently has a single readme for the three components and they all don't share the same props. |
I see. It makes a lot of sense. Do you think they should be moved to the top-level directory? The only challenge is that the following code would have to be imported for all of them: gutenberg/packages/components/src/date-time/index.js Lines 4 to 6 in 711f9ff
or moved to the top-level |
I don't know enough about what the Personally I'd preer the code to be in each component, since if someone is looking at using just the |
Hi @jpbelo, Sorry it took me so long to reply to you. I have checked the latest trunk and the three components are split into their own components and there is also Storybook. However, the README and Component Reference only exists for the It might be nice to have separate READMEs for This PR has the README for the above two components. Therefore, how about rebasing this PR to the latest trunk and keeping only the two READMEs? If you don't have time to work on it, I will gladly take it over 👍 |
Looks like there's no activity here anymore. I'm closing this PR. Feel free to open a new one if these efforts are to be restored since it needs to be redone entirely. Thanks for your efforts. |
Description
Moves DatePicker and TimePicker to their own Component.
Adds stories for DateTime, Date and Time pickers.
Adds
webpack-cli
to dev dependencies. (not sure if the scope of the issue allows this)How has this been tested?
The tests and functionality are the same as before. As the components work as expected on storybook I assumed the tests will pass.
I was not able to run tests locally.
Types of changes
Code improvement
Checklist:
Closes #18072