Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a tooltip to the block list appender. #13306

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Add a tooltip to the block list appender. #13306

merged 1 commit into from
Jan 14, 2019

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Jan 13, 2019

This PR adds a tooltip to the block list appender, by changing the Button used in the component to an IconButton.

Screenshot:

screenshot 2019-01-13 at 12 20 32

To test:

See #10136

Fixes #13305

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jan 13, 2019
@afercia afercia requested a review from youknowriad January 13, 2019 11:44
@afercia
Copy link
Contributor Author

afercia commented Jan 13, 2019

Note: the tooltip is even more important if this block appender is going to be the default, as proposed in #11329

aduth
aduth approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible, tests well 👍

@afercia afercia merged commit 338d889 into master Jan 14, 2019
@afercia afercia deleted the update/block-appender-tooltip branch January 14, 2019 12:21
@youknowriad youknowriad added this to the 4.9 (Gutenberg) milestone Jan 14, 2019
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@afercia @youknowriad
Add tooltip to the block list appender. (#13306)
c4120bf
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@afercia @youknowriad
Add tooltip to the block list appender. (#13306)
66a3278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Milestone
4.9 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
3 participants
@afercia @aduth @youknowriad