Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TextControl with label for post-publish permalink #10460

Conversation

chrisvanpatten
Copy link
Contributor

Fixes #9535.

Small change to the post-publish panel to use a TextControl with a "Permalink" label…

edit_page_ tomodomo wordpress_and_web_inspector dev_tomodomo_co _post_php

Also adjusted to use one of the grid-size variables.

It's a WIP because the click-to-select-text isn't working now that it's a TextControl instead of an input. Would love some help on that!

@chrisvanpatten chrisvanpatten added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Oct 10, 2018
@chrisvanpatten
Copy link
Contributor Author

This should be good for review!

Note: I replaced onFocus with onClick. This is due to some weird limitations around readonly inputs receiving focus. I am having a hard time finding a reference to this behaviour in any spec, but it's definitely A Thing™.

Even with the use of onClick instead of onFocus, the input content will receive focus in every case: keyboard navigation, clicking the label, or clicking the input.

@chrisvanpatten chrisvanpatten changed the title WIP: Use TextControl with label for post-publish permalink Use TextControl with label for post-publish permalink Oct 11, 2018
@chrisvanpatten
Copy link
Contributor Author

Hey @tofumatt — apologies for the ping, but this is ready for review :)

@chrisvanpatten
Copy link
Contributor Author

Closing in favor of #9536 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant