Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Editor Styles regression #10342

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Fix Editor Styles regression #10342

merged 1 commit into from
Oct 4, 2018

Conversation

youknowriad
Copy link
Contributor

Fixes a small regression introduced inadvertantly in #4217

Testing instructions

Make sure the editor styles are applied.

@youknowriad youknowriad self-assigned this Oct 4, 2018
@youknowriad youknowriad requested a review from jasmussen October 4, 2018 18:52
jasmussen
jasmussen approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ship it 🚢 🔥🚒🛳⛴

hamster

@jasmussen jasmussen added this to the 4.0 milestone Oct 4, 2018
@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Oct 4, 2018
@youknowriad youknowriad merged commit 9c3e5f9 into master Oct 4, 2018
@youknowriad youknowriad deleted the fix/small-regression-post-locking branch October 4, 2018 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmussen jasmussen jasmussen approved these changes

Assignees

@youknowriad youknowriad

Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowriad @jasmussen