Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backticks for code #703

Closed
jasmussen opened this issue May 8, 2017 · 6 comments
Closed

Backticks for code #703

jasmussen opened this issue May 8, 2017 · 6 comments
Assignees
@ellatrix
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Enhancement A suggestion for improvement.
Milestone
Beta 0.6.0

Comments

@jasmussen
Copy link
Contributor

When you write a backtick (```) before and after text in the current WordPress editor, you make code. We should port this.
@jasmussen jasmussen added [Feature] Blocks Overall functionality of blocks [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Enhancement A suggestion for improvement. labels May 8, 2017
@ellatrix
Copy link
Member

ellatrix commented May 8, 2017

Should we port all the shortcuts? Forgive me if there's already separate tickets. Might make sense as a whole though, technically, to add an API. Also, would love to work on this as I've done it for core. :D

@jasmussen
Copy link
Contributor Author

Should we port all the shortcuts? Forgive me if there's already separate tickets. Might make sense as a whole though, technically, to add an API. Also, would love to work on this as I've done it for core. :D

Yes! Port all the good stuff. And you seem the perfect person to work on it.

It's lower priority than some of the other issues, though, but once the milestone stuff is out of the way, definitely go for it!

@ellatrix ellatrix mentioned this issue May 8, 2017
Closed
@aduth
Copy link
Member

aduth commented May 8, 2017

Do you think it might be possible to use the same wptextpattern TinyMCE plugin verbatim?

@ellatrix
Copy link
Member

ellatrix commented May 8, 2017

It should work in any TinyMCE instance, yes.

@ellatrix
Copy link
Member

ellatrix commented May 8, 2017

I am hoping a bit to change the approach though.

@jasmussen jasmussen added this to the Beta milestone May 10, 2017
@ellatrix ellatrix self-assigned this May 22, 2017
@jasmussen jasmussen modified the milestones: May Week 4: Beta, May 29 to Jun 2, Beta, Beta, Nice To Have May 30, 2017
@mtias mtias modified the milestones: Beta 3, Beta, Nice To Have Jun 26, 2017
@ellatrix ellatrix mentioned this issue Jul 3, 2017
Merged
@mtias mtias modified the milestones: Beta 0.6.0, Beta 0.4.0 Jul 6, 2017
@mtias
Copy link
Member

mtias commented Jul 28, 2017

Done in #1674.

@mtias mtias closed this as completed Jul 28, 2017
@JasonHoffmann JasonHoffmann mentioned this issue Jan 4, 2018
Closed
2 tasks
@swissspidy swissspidy mentioned this issue Jan 23, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellatrix ellatrix

Labels
[Feature] Blocks Overall functionality of blocks [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Beta 0.6.0
Development

No branches or pull requests
4 participants
@mtias @jasmussen @aduth @ellatrix