Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with backticks #4290

Closed
2 tasks
JasonHoffmann opened this issue Jan 4, 2018 · 2 comments
Closed
2 tasks

Issue with backticks #4290

JasonHoffmann opened this issue Jan 4, 2018 · 2 comments
Assignees
Labels
[Type] Bug An existing feature does not function as intended
Milestone

Comments

@JasonHoffmann
Copy link
Contributor

JasonHoffmann commented Jan 4, 2018

Issue Overview

I'm running into an issue with the triple backtick (```) shortcut / fenced code blocks. In a paragraph block, if I type three backticks, it causes a bug where the backticks are overwritten by content, and do not create a code block. However, if I type three backticks (only one of which appears), then press "Enter" then "Backspace" a code block is created. A GIF is included below for clarity.

I didn't see this issue elsewhere, so I'm posting it.

Steps to Reproduce (for bugs)

  1. Create a new paragraph block
  2. Try typing backticks, then other content to see issue with backticks and content
  3. Create a new paragraph block again
  4. Type the backtick three times. Hit "Enter". Hit "Backspace". A codeblock will be created but not focused.

This is on version 1.9.1 of the plugin. I've tested it in Firefox and Chrome on a Mac.

Expected Behavior

Three backticks creates a code block.

Current Behavior

A backtick causes issues with formatting instead.

Screenshots / Video

http://g.recordit.co/ABMPrG7ifI.gif

Related Issues and/or PRs

#703

Todos

  • Tests
  • Documentation
@danielbachhuber danielbachhuber added the [Type] Bug An existing feature does not function as intended label Jan 23, 2018
@karmatosed karmatosed added this to the Merge Proposal milestone Jan 25, 2018
@jorgefilipecosta jorgefilipecosta self-assigned this Mar 15, 2018
@jeffpaul
Copy link
Member

This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs.

@jorgefilipecosta jorgefilipecosta added the [Status] In Progress Tracking issues with work in progress label Mar 23, 2018
@jorgefilipecosta jorgefilipecosta removed the [Status] In Progress Tracking issues with work in progress label Mar 27, 2018
@jorgefilipecosta
Copy link
Member

Thank @JasonHoffmann for reporting this issue, the merge of #5762 should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants