-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Screen: Always show appender #31276
Comments
CC: @javierarce in case you have any thoughts on a better approach! |
I think there's an indirect and less "invasive" way to solve this issue. If we fixed the hover state of the menu highlighting its border as I mentioned here, users would naturally understand that the menu is clickable. That said, I think your solution could work, and it's probably more accessible (although from a purely aesthetic perspective and to maintain the default behaviour, I wouldn't show an item that's not part of the menu). |
This is what I see with Gutenberg 10.5.3 activated. EDIT: Having the + icon button appender shows that the area can be interacted with. It is like a call for action to the user. |
This has become more important since #34568 was merged. Before that the navigation editor showed the FSE-style placeholder preview for an empty unselected navigation block: That was undesired, but what happens now is there's just an empty block: Fixing this does mean fighting with a lot of the block appender visibility logic. It has both code and styles for hiding the appender, most of which need to be revisited. |
What problem does this address?
The default menu on the navigation screen doesn't show the appender:
Not until the menu is selected:
This is the default behavior for inner-blocks, and the the navigation, even on this screen, is technically a block.
What is your proposed solution?
Extracting from #31228 (comment), maybe that plus should show up by default, even without the navigation block being selected first.
The text was updated successfully, but these errors were encountered: