Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Screen: Always show appender #31276

Closed
Tracked by #29102
jasmussen opened this issue Apr 28, 2021 · 5 comments · Fixed by #34678
Closed
Tracked by #29102

Navigation Screen: Always show appender #31276

jasmussen opened this issue Apr 28, 2021 · 5 comments · Fixed by #34678
Assignees
Labels
Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

What problem does this address?

The default menu on the navigation screen doesn't show the appender:

Screenshot 2021-04-28 at 12 28 05

Not until the menu is selected:

Screenshot 2021-04-28 at 12 28 35

This is the default behavior for inner-blocks, and the the navigation, even on this screen, is technically a block.

What is your proposed solution?

Extracting from #31228 (comment), maybe that plus should show up by default, even without the navigation block being selected first.

@jasmussen
Copy link
Contributor Author

CC: @javierarce in case you have any thoughts on a better approach!

@draganescu draganescu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. labels Apr 28, 2021
@javierarce
Copy link
Contributor

I think there's an indirect and less "invasive" way to solve this issue. If we fixed the hover state of the menu highlighting its border as I mentioned here, users would naturally understand that the menu is clickable.

That said, I think your solution could work, and it's probably more accessible (although from a purely aesthetic perspective and to maintain the default behaviour, I wouldn't show an item that's not part of the menu).

@paaljoachim
Copy link
Contributor

paaljoachim commented May 4, 2021

This is what I see with Gutenberg 10.5.3 activated.

Screen Shot 2021-05-04 at 18 54 37

EDIT:
I left the screen and came back again. This time no block inserter was seen by default.

Screen Shot 2021-05-04 at 18 58 54

Having the + icon button appender shows that the area can be interacted with. It is like a call for action to the user.
I do believe it will be helpful to have it on by default.

@spacedmonkey
Copy link
Member

Maybe the best solution to this problem, is to add the block inserter to navigation screen? This would keep the navigation screen inline other block editors.

Post editor

Screenshot 2021-08-30 at 23 24 31

Widget editor

Screenshot 2021-08-30 at 23 24 15

Navigation editor

Screenshot 2021-08-30 at 23 25 04

@talldan
Copy link
Contributor

talldan commented Sep 9, 2021

This has become more important since #34568 was merged.

Before that the navigation editor showed the FSE-style placeholder preview for an empty unselected navigation block:
Screenshot 2021-09-06 at 3 49 11 pm

That was undesired, but what happens now is there's just an empty block:
Screenshot 2021-09-09 at 1 03 48 pm

Fixing this does mean fighting with a lot of the block appender visibility logic. It has both code and styles for hiding the appender, most of which need to be revisited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
6 participants