-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editing: It is not clear at-a-glance whether one is editing a template or an item of content #27849
Comments
One option here would be to use different color treatments on landmark UI elements to help indicate which context you are in. For example, we might invert the top bar and toolbars when template editing: In addition to this, some simple animation that occurs as one transitions between editing content and template might help as well: |
That seems great. |
Oops, for some reason the template name is missing in the gif above. Here's an updated version: I'm a little hesitant to add red to the UI since that is generally used for destructive actions like deletion. Instead I think some kind of welcome guide the first time a user encounters the template editor, and explains the concepts therein might work better. We don't have an issue for that yet, but it is mentioned in #27814. Here's a very rough example of how that might work: |
I understand. But this kind of falls under destruction level :) A welcome message is always good but I tend to skip them and they tend to be annoying, specially if you work on multiple projects (an option to opt out - until opposite notice?) This is just a quick printscreen draft with some mixed (or not) solutions for comparison, to see if something feels good.. |
Could you elaborate on your thoughts there? I don't see anything destructive here, it is still editing, just editing a different thing :)
The idea here is that the inverted top bar is enough to remind you that you are editing a template rather than content. To clarify – when you're editing content (posts/pages) the top bar is white, and when you're editing a template it is black. If one misses such a dramatic change, I'm not sure that changing the button color is going to make much difference :D In your mockup I noticed you have the template name twice, what is the thinking there? I also noticed that you added a back button, I like the idea of offering users a shortcut back to the thing they were editing a lot :) |
It was just to alert a more distracted user to a change in all posts (red is also for that - like the updates alert).
I imagined it could be easier to distinguish between a lot of templates, CPTs, Pages, etc. And if you have a "centralized" working area/workflow for templates. |
I would first start out in a subtile way. No animation or changing color from white to black. We can give many hints that one is going from a post to a template. For instance the Post - Block tabs at the top of the settings sidebar area. Top bar title. That is atleast a nice and soft start. Taking it one step at a time..:) |
As I mentioned here, I'm not sure this is a part of the UX to exercise subtlety. If the change is not bold, then the issue described in the OP is not fully addressed. It's important the user understands that templates are totally separate from content, and consequently when they are editing one or the other. That said, animation and color are just two ways we might communicate this shift in context. We should use this issue to explore other options for sure! EDIT: Including this quote from the FSE Outreach Program summary. On "Distinction between editing modes (template vs page/post)":
|
EDIT: |
We've added an outline to template parts when innerblocks are being edited already :) Further exploration around how to indicate when one is editing template vs content, and how to move between views, can be seen in this issue/comment. |
I would do the simplest thing: The flow I'm thinking inside FSE:
If I'm on post editor it will be viceversa. I hope I have well explained the flow I have in mind. |
@overclokk This sounds similar to something we're exploring for reusable blocks in #29337. |
@jameskoster I just saw but I was thinking to also lock the content inside the FSE, I don't want to accidentally modify the content or the title. |
I have been playing with the thought of having a lock icon in the toolbar for reusable blocks and for FSE template blocks. |
@paaljoachim I'm optimistic that the Overlay we were discussing in #29337 will serve as a pseudo-lock effect. An actual lock icon feels a little heavy handed, and may draw people to interact with it, which would actually add more friction that simply clicking through. |
Hey James @jameskoster |
In the page content one sees a mention of Template then page (Edit). Step 1: Click Edit to switch to Full Site Editing. Currently the below screenshot merges the above two steps into one action. In the below video I am focusing on step 1 to switch to Full Site Editing. Here is an update to switching between Page content and Full Site Editing content. Switch-Page-Full-Site.mp4Figma protytype (can be scrolled) |
I dig this attempt! My only concern is that it's almost too smooth of a switch. I feel like there needs to be some good friction particularly when switching to edit the full site. Perhaps that's the idea of having a notice pop up once one does switch over. |
Thanks for sharing more ideas @paaljoachim!
I'm not sure we need to distinguish the experience in these steps. Modifying a template (or template part for that matter which may occur while editing content) is full site editing. The notion of FSE being this discrete experience that people move in and out of is something I'm not convinced we should actively encourage. I still see WordPress itself as the Site Editor, and within it there are different views for editing content, templates, reusable blocks, block patterns, styles, and so on. The key is to knit those features together in a way that feels seamless while still providing the necessary clarity as outlined in the OP. I fear that adding more steps only serves to fragment and harm the overall UX. It may not be the final solution, but I happen to think there is something nice about the simple and explicit "Template: Page (edit)" implementation we currently have. It is crystal clear that from there I am able to go and edit the template applied to the content on the canvas. All that said, I'd like to share another idea that @jasmussen and I discussed recently which riffs on my original suggestion of using color to differentiate between the views. In recent design work around site editing concepts such as isolated template part editing and the template mosaic view this idea of exposing the surface behind the canvas has come up: It's a simple but powerful idea that enables us to build on this concept of zooming in and out of different views, which is something that Matias has mentioned several times in the past. It could make sense to use this affordance to satisfy the issues outlined in the OP. Here's a rough demo that stitches those ideas all together: site.editing.mp4There is a lot still to be explored here, but I'd love to hear thoughts around this concept. |
Very much agree with Jay here: full site editing is both post editing, and site editing, and this should be kept in mind when conveying the switch. A button in the sidebar was the smallest thing we could do, but it's not something we should optimize for long term: it doesn't scale to mobile, and it doesn't sufficiently convey the context shift. Any change to this switching interface should probably be designed to exist outside the sidebar entirely. The idea that Jay is sharing, of literally zooming out when you go from post to template editing, I also believe is where we wil ultimately need to go. It alludes to "seeing the full picture", and the animated shift can help visually convey context even beyond "now you're editing the template", perhaps up to and including swapping out templates in a mosaic view, or even swapping out sections of a page in an exploded view. Getting the whole flow right is going to be a very difficult endeavour, and the difficult part is figuring out which of these ingredients we can start to use today, without compromising the larger vision. Showing the gray frame around the content for the template editing context is likely going to play a part in that vision, but I can't figure out whether it's a good first step to take without changes also to the separate site editor item. But the benefit would be that it would provide a big visual shift, solving the crux of the issue. |
Hey James I feel you are onto something with the zoom in <-> out of various parts when in Full Site Editing. This is really interesting, James! The above shows Full Site Editing view and edit. |
I think we could potentially use something similar to the click-through pattern we're currently exploring for Reusable Blocks (#29337): back.to.content.mp4Consequently this is another use case for block locking (#29864) – note how I am not able to move the post title block while editing the post itself. |
A gradual evolution of FSE and post/page content creation. What you are suggesting, James is a much bigger leap in evolution. Should we go with something I suggested just to improve the current method? If the purpose is to create a MVP to be made available in the beginning of April, then we need to make sure that we create small adjustments making it ready for folks to test out. Having a MVP ready in the beginning of April will make it possible for a huge amount of people to test and give feedback. |
It's a bigger leap when you consider the isolated template part / mosaic views, and contextual block locking. But those are being handled in other issues and the dots will hopefully connect organically as we close them out. I don't believe that introducing the "frame" around the template as you switch from content editing to template editing is all that much work. Especially if we leave out the animation initially. I just put this together in a couple of minutes in the browser inspector: inspector.mp4All that to say, it's probably worth getting input from a developer as this point, in particular around the transition between content <> template editing in this comment, including the "back" button that appears above the canvas. If it's not too much work, perhaps we can get a try PR together? |
What we can do is add the "Needs dev" label. I also went ahead and removed the "Needs Design" and the "Needs Design Feedback" labels. (It can of course be changed if there is a need to do so.) |
Let's close this one, good call. It's so easy to reopen if it was in error 👍 👍 |
Once it is possible to view the template whilst editing a post or page (#27847), it will no longer be easy to tell at a glance what is being edited – the content or the template. Consider the screenshot below:
On the left I am editing my “Hello World” post (while viewing template), on the right I am editing my “Post” template directly. You need an eagle-eye to identify which instance is which, so we should investigate some additional visual cues in the UI to make this distinction more obvious.
The text was updated successfully, but these errors were encountered: