Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editing Infrastructure and UI: Part 3 #27814

Closed
9 of 17 tasks
youknowriad opened this issue Dec 18, 2020 · 12 comments
Closed
9 of 17 tasks

Site Editing Infrastructure and UI: Part 3 #27814

youknowriad opened this issue Dec 18, 2020 · 12 comments
Labels
[Feature] Templates API Related to API powering block template functionality in the Site Editor [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues

Comments

@youknowriad
Copy link
Contributor

youknowriad commented Dec 18, 2020

In #26355 we've introduced an initial version for the template editor mode in the post editor. This highlighted a few issues in the design/flows of that feature. The current issue is an overview tracking the progress for all oft these follow-ups:

Blank Canvas Template

Interface

Infrastructure

@youknowriad youknowriad added [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues [Feature] Full Site Editing labels Dec 18, 2020
@mtias mtias changed the title FSE: Template Mode in post editor Template editing mode within the post editor Dec 19, 2020
@mtias mtias added the [Feature] Templates API Related to API powering block template functionality in the Site Editor label Dec 19, 2020
@skorasaurus
Copy link
Member

One more suggestion to add: While editing a template within the post editor, I went to the code editor mode, and the code editor mode returned the content of the post, not the template's content (what I expected); this is a result of #22528

@youknowriad
Copy link
Contributor Author

#30438 is now merged so classic themes can use blocks to build custom templates for pages and all CPTs that support Page templates now.

@priethor
Copy link
Contributor

Added Allow themes to opt-in/out of the "Create new template" flow to the list.

@youknowriad
Copy link
Contributor Author

Added Allow themes to opt-in/out of the "Create new template" flow to the list.

That's already possible with the block-templates support flag. you can do remove_theme_support( 'block-templates' );

@carolinan
Copy link
Contributor

Short term, are the template and template part menus under Appearance going to be in 5.8?

If not:

  • How can user created templates be deleted?
  • Editing templates is possible, but you would first have to find a page or post that uses that template, or create a new page or post just to access that template.
  • How can users edit templates that are not post or pages, such as search, archive, and 404?

If kept:
The editing views in the appearance>edit templates and block editor>edit template are not the same.
What is the intention with these separate views?

@youknowriad
Copy link
Contributor Author

I think these screens are not meant to be shipped at all. So yeah if the template editor makes it to 5.8, we need at least a "delete" template somewhere in the template mode or the template panel.

@jameskoster
Copy link
Contributor

How can users edit templates that are not post or pages, such as search, archive, and 404?

Assuming dedicated template management (IE Appearance > Templates) doesn't ship in 5.8, it won't be possible to create these templates in the UI. So I think it's fair to assume there will not be an expectation of edit-ability either.

we need at least a "delete" template somewhere in the template mode or the template panel

There is a revert affordance for customised block theme templates in the site editor. We can use that same design for deletion in the template editor. I'll make an issue.

@carolinan
Copy link
Contributor

carolinan commented Apr 22, 2021

it won't be possible to create these templates in the UI
You meant in the appearance > templates UI? Or not create templates at all via any sort of UI 😕

@jameskoster
Copy link
Contributor

Not create the templates you mentioned specifically: search, archive, 404, etc.

@priethor
Copy link
Contributor

we need at least a "delete" template somewhere in the template mode or the template panel.

Added this to the list based on the recently created #31076

@adamziel
Copy link
Contributor

adamziel commented Apr 1, 2022

Is there any feature here that could still land until Wednesday next week to be included in WordPress 6.0 release? To increase visibility, we can add it to the WordPress Editor 6.0 project board.

@mtias
Copy link
Member

mtias commented May 23, 2022

Time for a new reset: #41241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Templates API Related to API powering block template functionality in the Site Editor [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues
Projects
No open projects
Archived in project
Development

No branches or pull requests

7 participants