Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resized center-aligned images do not appear centered in the editor. #21152

Closed
kjellr opened this issue Mar 25, 2020 · 5 comments
Closed

Resized center-aligned images do not appear centered in the editor. #21152

kjellr opened this issue Mar 25, 2020 · 5 comments
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Mar 25, 2020 •
edited
Loading

Steps to reproduce

  1. Add an image.
  2. Resize it to be a custom size using the handles or the sidebar.
  3. Set the image to be center-aligned.
  4. Observe that the image appears to be left-aligned, instead of centered.

Screenshot / Video

resize-align-center

^ Gutenberg Starter Theme

Details

Tested in Safari 13.0.5, using Gutenberg 7.71 and 7.8.0-rc.1.
Tried with Twenty Twenty and also the Gutenberg Starter Theme
@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block labels Mar 25, 2020
@kjellr kjellr mentioned this issue Mar 25, 2020
Closed
@ccwalburn ccwalburn mentioned this issue Mar 25, 2020
Closed
@roo2
Copy link
Contributor

roo2 commented Mar 26, 2020 •
edited
Loading

Have a pr up to fix this #21160

roo2 added a commit to roo2/gutenberg that referenced this issue Mar 26, 2020
@roo2
Revert "Light block: automatically add block class (WordPress#20658)"…
9987674 
… due to issues:

WordPress#21152
WordPress#21114

This reverts commit 8a94254.
@roo2 roo2 mentioned this issue Mar 26, 2020
Closed
6 tasks
@mikeicode
Copy link

This came up 19688573-hc

@roo2
Copy link
Contributor

roo2 commented Mar 30, 2020

May be fixed by #21167

@scosgro
Copy link

scosgro commented Mar 31, 2020 •
edited
Loading

This was replicated on the WordPress.com end as well. +1

@noahtallen
Copy link
Member

noahtallen commented Apr 6, 2020 •
edited
Loading

I just tested this locally on the latest master branch and could not replicate, so I'll assume it was resolved by #21167 unless folks have other concerns. The fix should be in the next Gutenberg Plugin release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert #20658 due to issues with image placement and selection roo2/gutenberg
5 participants
@kjellr @noahtallen @mikeicode @roo2 @scosgro