Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Center-Alignment for Headings and Images with Gutenberg #1856

Closed
ianstewart opened this issue Mar 19, 2020 · 4 comments
Closed

Missing Center-Alignment for Headings and Images with Gutenberg #1856

ianstewart opened this issue Mar 19, 2020 · 4 comments

Comments

@ianstewart
Copy link
Contributor

A few of our free themes are missing center-alignment for headings and images.

Twenty Nineteen has offset headings when they're center-aligned.

Sketch does not correctly center-align images. Neither does Franklin.

image

Related:

Automattic/wp-calypso#28756

cc @lancewillett

@lancewillett
Copy link

Thanks for tracking it down, @ianstewart

@kjellr
Copy link
Contributor

kjellr commented Mar 25, 2020

Twenty Nineteen needs a patch in core to fix those headers. I've created one here: https://core.trac.wordpress.org/ticket/49699

As for Sketch and Franklin, I've tested these on my end and I'm only able to consistently recreate in the editor, and only when I follow the following steps:

  1. Add an image.
  2. Resize it to be a custom size using the handles or the sidebar.
  3. Set the image to be center-aligned.

This appears to be a general Gutenberg bug, since I see it in all themes. I've filed a bug here: WordPress/gutenberg#21152

Otherwise, images appear to be center-aligned just fine:

Screen Shot 2020-03-25 at 11 55 07 AM

Is there something I should do differently to reproduce?

@ianstewart
Copy link
Contributor Author

Is there something I should do differently to reproduce?

Huh. Strange. Could be related to the preview method I used?

@mrfoxtalbot
Copy link

I ran a few tests with both Sketch and Franklin but I can no longer reproduce this so I am going to close this issue.

Screen.Capture.on.2022-06-17.at.13-41-47.mov

@mrfoxtalbot mrfoxtalbot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants