Use dashes instead of underscores for consistency with other actions (#…

…10256)
WordPress · Oct 4, 2018 · fce0317 · fce0317
1 parent 10e8751
commit fce0317
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/lib/rest-api.php b/lib/rest-api.php
@@ -255,7 +255,7 @@ function gutenberg_add_target_schema_to_links( $response, $post, $request ) {
 	$post_type  = get_post_type_object( $post->post_type );
 	$orig_href  = ! empty( $orig_links['self'][0]['href'] ) ? $orig_links['self'][0]['href'] : null;
 	if ( 'edit' === $request['context'] && current_user_can( 'unfiltered_html' ) ) {
-		$new_links['https://api.w.org/action-unfiltered_html'] = array(
+		$new_links['https://api.w.org/action-unfiltered-html'] = array(
 			array(
 				'title'        => __( 'The current user can post HTML markup and JavaScript.', 'gutenberg' ),
 				'href'         => $orig_href,

diff --git a/packages/editor/src/store/selectors.js b/packages/editor/src/store/selectors.js
@@ -1952,7 +1952,7 @@ export function getTokenSettings( state, name ) {
  * @return {boolean} Whether the user can or can't post unfiltered HTML.
  */
 export function canUserUseUnfilteredHTML( state ) {
-	return has( getCurrentPost( state ), [ '_links', 'wp:action-unfiltered_html' ] );
+	return has( getCurrentPost( state ), [ '_links', 'wp:action-unfiltered-html' ] );
 }
 
 /**

diff --git a/packages/editor/src/store/test/selectors.js b/packages/editor/src/store/test/selectors.js
@@ -4158,17 +4158,17 @@ describe( 'selectors', () => {
 	} );
 
 	describe( 'canUserUseUnfilteredHTML', () => {
-		it( 'should return true if the _links object contains the property wp:action-unfiltered_html', () => {
+		it( 'should return true if the _links object contains the property wp:action-unfiltered-html', () => {
 			const state = {
 				currentPost: {
 					_links: {
-						'wp:action-unfiltered_html': [],
+						'wp:action-unfiltered-html': [],
 					},
 				},
 			};
 			expect( canUserUseUnfilteredHTML( state ) ).toBe( true );
 		} );
-		it( 'should return false if the _links object doesnt contain the property wp:action-unfiltered_html', () => {
+		it( 'should return false if the _links object doesnt contain the property wp:action-unfiltered-html', () => {
 			const state = {
 				currentPost: {
 					_links: {},

diff --git a/phpunit/class-gutenberg-rest-api-test.php b/phpunit/class-gutenberg-rest-api-test.php
@@ -116,7 +116,7 @@ function test_viewable_field_without_context() {
 	 */
 	function test_link_unfiltered_html() {
 		$post_id   = $this->factory->post->create();
-		$check_key = 'https://api.w.org/action-unfiltered_html';
+		$check_key = 'https://api.w.org/action-unfiltered-html';
 		// admins can in a single site, but can't in a multisite.
 		wp_set_current_user( $this->administrator );
 		$request = new WP_REST_Request( 'GET', '/wp/v2/posts/' . $post_id );