Cover Image: Ensure backcompat via default attributes

WordPress · Sep 29, 2017 · eab53ef · eab53ef
1 parent f6ae7fe
commit eab53ef
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 11 deletions.
diff --git a/blocks/library/cover-image/index.js b/blocks/library/cover-image/index.js
@@ -51,7 +51,7 @@ registerBlockType( 'core/cover-image', {
 		},
 		dimRatio: {
 			type: 'number',
-			default: 0,
+			default: 50,
 		},
 	},
 
@@ -191,7 +191,7 @@ registerBlockType( 'core/cover-image', {
 } );
 
 function dimRatioToClass( ratio ) {
-	return ratio === 0
+	return ( ratio === 0 || ratio === 50 )
 		? null
 		: 'has-background-dim-' + Math.round( ratio / 10 );
 }
diff --git a/blocks/library/cover-image/style.scss b/blocks/library/cover-image/style.scss
@@ -29,7 +29,7 @@
 		left: 0;
 		bottom: 0;
 		right: 0;
-		background: rgba( black, 0 );
+		background: rgba( black, 0.5 );
 	}
 
 	@for $i from 1 through 10 {

diff --git a/blocks/test/fixtures/core__cover-image.html b/blocks/test/fixtures/core__cover-image.html
@@ -1,5 +1,5 @@
-<!-- wp:core/cover-image {"url":"https://cldup.com/uuUqE_dXzy.jpg","dimRatio":50} -->
-<section class="wp-block-cover-image has-background-dim-5 has-background-dim" style="background-image:url(https://cldup.com/uuUqE_dXzy.jpg);">
+<!-- wp:core/cover-image {"url":"https://cldup.com/uuUqE_dXzy.jpg","dimRatio":40} -->
+<section class="wp-block-cover-image has-background-dim-4 has-background-dim" style="background-image:url(https://cldup.com/uuUqE_dXzy.jpg);">
     <h2>Guten Berg!</h2>
 </section>
 <!-- /wp:core/cover-image -->
diff --git a/blocks/test/fixtures/core__cover-image.json b/blocks/test/fixtures/core__cover-image.json
@@ -9,8 +9,8 @@
             ],
             "url": "https://cldup.com/uuUqE_dXzy.jpg",
             "hasParallax": false,
-            "dimRatio": 50
+            "dimRatio": 40
         },
-        "originalContent": "<section class=\"wp-block-cover-image has-background-dim-5 has-background-dim\" style=\"background-image:url(https://cldup.com/uuUqE_dXzy.jpg);\">\n    <h2>Guten Berg!</h2>\n</section>"
+        "originalContent": "<section class=\"wp-block-cover-image has-background-dim-4 has-background-dim\" style=\"background-image:url(https://cldup.com/uuUqE_dXzy.jpg);\">\n    <h2>Guten Berg!</h2>\n</section>"
     }
 ]
diff --git a/blocks/test/fixtures/core__cover-image.parsed.json b/blocks/test/fixtures/core__cover-image.parsed.json
@@ -3,9 +3,9 @@
         "blockName": "core/cover-image",
         "attrs": {
             "url": "https://cldup.com/uuUqE_dXzy.jpg",
-            "dimRatio": 50
+            "dimRatio": 40
         },
-        "rawContent": "\n<section class=\"wp-block-cover-image has-background-dim-5 has-background-dim\" style=\"background-image:url(https://cldup.com/uuUqE_dXzy.jpg);\">\n    <h2>Guten Berg!</h2>\n</section>\n"
+        "rawContent": "\n<section class=\"wp-block-cover-image has-background-dim-4 has-background-dim\" style=\"background-image:url(https://cldup.com/uuUqE_dXzy.jpg);\">\n    <h2>Guten Berg!</h2>\n</section>\n"
     },
     {
         "attrs": {},

diff --git a/blocks/test/fixtures/core__cover-image.serialized.html b/blocks/test/fixtures/core__cover-image.serialized.html
@@ -1,5 +1,5 @@
-<!-- wp:core/cover-image {"url":"https://cldup.com/uuUqE_dXzy.jpg","dimRatio":50} -->
-<section class="wp-block-cover-image has-background-dim-5 has-background-dim" style="background-image:url(https://cldup.com/uuUqE_dXzy.jpg);">
+<!-- wp:core/cover-image {"url":"https://cldup.com/uuUqE_dXzy.jpg","dimRatio":40} -->
+<section class="wp-block-cover-image has-background-dim-4 has-background-dim" style="background-image:url(https://cldup.com/uuUqE_dXzy.jpg);">
     <h2>Guten Berg!</h2>
 </section>
 <!-- /wp:core/cover-image -->