Post Template: fix broken title editing (#49984)

* Post template title edit: update only the avaiableTemplates setting * Post template title edit: fix broken rename code
WordPress · Apr 21, 2023 · e92348d · e92348d
1 parent 6b9b84d
commit e92348d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/packages/edit-post/src/components/header/template-title/delete-template.js b/packages/edit-post/src/components/header/template-title/delete-template.js
@@ -59,7 +59,6 @@ export default function DeleteTemplate() {
 			)
 		);
 		updateEditorSettings( {
-			...settings,
 			availableTemplates: newAvailableTemplates,
 		} );
 		deleteEntityRecord( 'postType', 'wp_template', template.id, {

diff --git a/packages/edit-post/src/components/header/template-title/edit-template-title.js b/packages/edit-post/src/components/header/template-title/edit-template-title.js
@@ -58,16 +58,13 @@ export default function EditTemplateTitle() {
 					const settings = getEditorSettings();
 					const newAvailableTemplates = Object.fromEntries(
 						Object.entries( settings.availableTemplates ?? {} ).map(
-							( [ id, existingTitle ] ) => {
-								if ( id !== template.slug ) {
-									return existingTitle;
-								}
-								return newTitle;
-							}
+							( [ id, existingTitle ] ) => [
+								id,
+								id !== template.slug ? existingTitle : newTitle,
+							]
 						)
 					);
 					updateEditorSettings( {
-						...settings,
 						availableTemplates: newAvailableTemplates,
 					} );
 					editEntityRecord( 'postType', 'wp_template', template.id, {