Skip to content

Commit

Permalink
Revert even more false positives
Browse files Browse the repository at this point in the history
  • Loading branch information
szepeviktor committed Nov 26, 2024
1 parent 73cceea commit d794037
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/eslint-plugin/utils/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const TRANSLATION_FUNCTIONS = new Set( [ '__', '_x', '_n', '_nx' ] );
* >The rest of the string can contain the same characters, plus any U+200C zero
* >width non-joiner characters, U+200D zero width joiner characters, and
* >characters in the Unicode categories “Non-spacing mark (Mn)”, “Spacing
* >combining mark (Mc)”, “Decimal digit number (And)”, or “Connector
* >combining mark (Mc)”, “Decimal digit number (Nd)”, or “Connector
* >punctuation (Pc)”.
*
* If browser support is constrained to those supporting ES2015, this could be
Expand Down
2 changes: 1 addition & 1 deletion packages/hooks/src/test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ test( 'remove specific filter callback', () => {
addFilter( 'test.filter', 'my_callback_filter_c', filterC, 8 );

expect( removeFilter( 'test.filter', 'my_callback_filter_b' ) ).toBe( 1 );
expect( applyFilters( 'test.filter', 'test' ) ).toBe( 'testcase' );
expect( applyFilters( 'test.filter', 'test' ) ).toBe( 'testca' );
} );

test( 'filter removes a callback that has already executed', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-aztec/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ plugins {
id "com.android.library"
id "org.jetbrains.kotlin.android"
id "maven-publish"
id "com.automatic.android.publish-to-s3"
id "com.automattic.android.publish-to-s3"
}

// import the `readReactNativeVersion()` function
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ const setupDriver = async () => {
if ( isLocalEnvironment() ) {
const androidDeviceID = getAndroidEmulatorID();
desiredCaps.app = path.resolve( localAndroidAppPath );
desiredCaps.uuid = androidDeviceID;
desiredCaps.udid = androidDeviceID;
try {
const androidVersion = childProcess
.execSync(
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-editor/bin/test-e2e-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ function detect_or_create_simulator() {
local simulator_name=$1
local runtime_name_display=$(echo "iOS $IOS_PLATFORM_VERSION")
local runtime_name=$(echo "$runtime_name_display" | sed 's/ /-/g; s/\./-/g')
local simulators=$(xcrun simctl list devices -j | jq -r --arg runtime "$runtime_name" '.devices | to_entries[] | select(.key | contains($runtime)) | .value[] | .name + "," + .uuid')
local simulators=$(xcrun simctl list devices -j | jq -r --arg runtime "$runtime_name" '.devices | to_entries[] | select(.key | contains($runtime)) | .value[] | .name + "," + .udid')

if ! echo "$simulators" | grep -q "$simulator_name"; then
log_info "$simulator_name ($runtime_name_display) not found, creating..."
Expand Down

0 comments on commit d794037

Please sign in to comment.