Update percentage strings to be translatable (#66323)

* Update percentage strings to be translatable * Fix js lint errors * Revert unexpected changes * Add translation for button block * Use integer instead of string placeholders Co-authored-by: AhmarZaidi <[email protected]> Co-authored-by: t-hamano <[email protected]>
WordPress · Jan 3, 2025 · 8dd99ed · 8dd99ed
1 parent 89de183
commit 8dd99ed
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/packages/block-editor/src/components/image-size-control/index.js b/packages/block-editor/src/components/image-size-control/index.js
@@ -8,7 +8,7 @@ import {
 	__experimentalToggleGroupControl as ToggleGroupControl,
 	__experimentalToggleGroupControlOption as ToggleGroupControlOption,
 } from '@wordpress/components';
-import { __ } from '@wordpress/i18n';
+import { __, sprintf } from '@wordpress/i18n';
 
 /**
  * Internal dependencies
@@ -137,7 +137,11 @@ export default function ImageSizeControl( {
 								<ToggleGroupControlOption
 									key={ scale }
 									value={ scale }
-									label={ `${ scale }%` }
+									label={ sprintf(
+										/* translators: Percentage value. */
+										__( '%1$d%%' ),
+										scale
+									) }
 								/>
 							);
 						} ) }

diff --git a/packages/block-library/src/button/edit.js b/packages/block-library/src/button/edit.js
@@ -14,7 +14,7 @@ import { useToolsPanelDropdownMenuProps } from '../utils/hooks';
 /**
  * WordPress dependencies
  */
-import { __ } from '@wordpress/i18n';
+import { __, sprintf } from '@wordpress/i18n';
 import { useEffect, useState, useRef, useMemo } from '@wordpress/element';
 import {
 	TextControl,
@@ -148,7 +148,11 @@ function WidthPanel( { selectedWidth, setAttributes } ) {
 							<ToggleGroupControlOption
 								key={ widthValue }
 								value={ widthValue }
-								label={ `${ widthValue }%` }
+								label={ sprintf(
+									/* translators: Percentage value. */
+									__( '%1$d%%' ),
+									widthValue
+								) }
 							/>
 						);
 					} ) }

diff --git a/packages/block-library/src/search/edit.js b/packages/block-library/src/search/edit.js
@@ -34,7 +34,7 @@ import {
 } from '@wordpress/components';
 import { useInstanceId } from '@wordpress/compose';
 import { Icon, search } from '@wordpress/icons';
-import { __ } from '@wordpress/i18n';
+import { __, sprintf } from '@wordpress/i18n';
 import { __unstableStripHTML as stripHTML } from '@wordpress/dom';
 
 /**
@@ -470,7 +470,11 @@ export default function SearchEdit( {
 									<ToggleGroupControlOption
 										key={ widthValue }
 										value={ widthValue }
-										label={ `${ widthValue }%` }
+										label={ sprintf(
+											/* translators: Percentage value. */
+											__( '%1$d%%' ),
+											widthValue
+										) }
 									/>
 								);
 							} ) }