Use generated Ids for id prop of faux suggestions rather than ever …

…decrementing static negative numbers
WordPress · Feb 10, 2020 · 2295338 · 2295338
1 parent 73eb46f
commit 2295338
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/packages/block-editor/src/components/link-control/index.js b/packages/block-editor/src/components/link-control/index.js
@@ -2,7 +2,7 @@
  * External dependencies
  */
 import classnames from 'classnames';
-import { noop, startsWith } from 'lodash';
+import { noop, startsWith, uniqueId } from 'lodash';
 
 /**
  * WordPress dependencies
@@ -188,9 +188,9 @@ function LinkControl( {
 			type = 'internal';
 		}
 
-		return Promise.resolve( [
-			{
-				id: '-1',
+		return Promise.resolve(
+			[ {
+				id: uniqueId(),
 				title: val,
 				url: type === 'URL' ? prependHTTP( val ) : val,
 				type,
@@ -223,7 +223,7 @@ function LinkControl( {
 		// the a11y benefits afforded by `URLInput` to all suggestions (eg:
 		// keyboard handling, ARIA roles...etc).
 		return results.concat( {
-			id: '-2',
+			id: uniqueId(),
 			? results[ 0 ].concat( results[ 1 ] )
 			title: '',
 			url: '',