Use isKeyboardEvent to catch key combination + improve comment

WordPress · Aug 13, 2018 · 178325e · 178325e
1 parent 46ccb19
commit 178325e
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/packages/editor/src/components/rich-text/index.js b/packages/editor/src/components/rich-text/index.js
@@ -23,7 +23,7 @@ import {
 	getScrollContainer,
 } from '@wordpress/dom';
 import { createBlobURL } from '@wordpress/blob';
-import { BACKSPACE, DELETE, ENTER, LEFT, RIGHT, rawShortcut } from '@wordpress/keycodes';
+import { BACKSPACE, DELETE, ENTER, LEFT, RIGHT, rawShortcut, isKeyboardEvent } from '@wordpress/keycodes';
 import { Slot } from '@wordpress/components';
 import { withSelect } from '@wordpress/data';
 import { rawHandler, children } from '@wordpress/blocks';
@@ -397,11 +397,12 @@ export class RichText extends Component {
 			return;
 		}
 
-		const { keyCode, altKey, metaKey } = event;
+		const { keyCode } = event;
 		const isReverse = keyCode === BACKSPACE;
 
 		// User is using the Remove Block shortcut, so allow the event to bubble
-		if ( altKey && metaKey && isReverse ) {
+		// up to the BlockSettingsMenu component
+		if ( isKeyboardEvent.primaryAlt( event, 'Backspace' ) ) {
 			return;
 		}