Image: Mark connected controls as 'readyonly' (#59059)

* Image: Mark connected controls as 'readyonly' * Update e2e tests Co-authored-by: Mamaduka <[email protected]> Co-authored-by: michalczaplinski <[email protected]> Co-authored-by: afercia <[email protected]> # Conflicts: # test/e2e/specs/editor/various/block-bindings.spec.js
WordPress · Feb 20, 2024 · 0a92dc2 · 0a92dc2
1 parent 245d24e
commit 0a92dc2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/packages/block-library/src/image/image.js b/packages/block-library/src/image/image.js
@@ -634,7 +634,7 @@ export default function Image( {
 								label={ __( 'Alternative text' ) }
 								value={ alt || '' }
 								onChange={ updateAlt }
-								disabled={ lockAltControls }
+								readOnly={ lockAltControls }
 								help={
 									lockAltControls ? (
 										<>
@@ -676,7 +676,7 @@ export default function Image( {
 					label={ __( 'Title attribute' ) }
 					value={ title || '' }
 					onChange={ onSetTitle }
-					disabled={ lockTitleControls }
+					readOnly={ lockTitleControls }
 					help={
 						lockTitleControls ? (
 							<>{ __( 'Connected to a custom field' ) }</>

diff --git a/test/e2e/specs/editor/various/block-bindings.spec.js b/test/e2e/specs/editor/various/block-bindings.spec.js
@@ -565,7 +565,7 @@ test.describe( 'Block bindings', () => {
 					page
 						.getByRole( 'tabpanel', { name: 'Settings' } )
 						.getByLabel( 'Alternative text' )
-				).toBeDisabled();
+				).toHaveAttribute( 'readonly' );
 				const altValue = await page
 					.getByRole( 'tabpanel', { name: 'Settings' } )
 					.getByLabel( 'Alternative text' )
@@ -644,7 +644,7 @@ test.describe( 'Block bindings', () => {
 					page
 						.getByRole( 'tabpanel', { name: 'Settings' } )
 						.getByLabel( 'Title attribute' )
-				).toBeDisabled();
+				).toHaveAttribute( 'readonly' );
 				const titleValue = await page
 					.getByRole( 'tabpanel', { name: 'Settings' } )
 					.getByLabel( 'Title attribute' )
@@ -700,7 +700,7 @@ test.describe( 'Block bindings', () => {
 					page
 						.getByRole( 'tabpanel', { name: 'Settings' } )
 						.getByLabel( 'Alternative text' )
-				).toBeDisabled();
+				).toHaveAttribute( 'readonly' );
 				const altValue = await page
 					.getByRole( 'tabpanel', { name: 'Settings' } )
 					.getByLabel( 'Alternative text' )
@@ -1108,7 +1108,7 @@ test.describe( 'Block bindings', () => {
 					page
 						.getByRole( 'tabpanel', { name: 'Settings' } )
 						.getByLabel( 'Alternative text' )
-				).toBeDisabled();
+				).toHaveAttribute( 'readonly' );
 				const altValue = await page
 					.getByRole( 'tabpanel', { name: 'Settings' } )
 					.getByLabel( 'Alternative text' )
@@ -1184,7 +1184,7 @@ test.describe( 'Block bindings', () => {
 					page
 						.getByRole( 'tabpanel', { name: 'Settings' } )
 						.getByLabel( 'Title attribute' )
-				).toBeDisabled();
+				).toHaveAttribute( 'readonly' );
 				const titleValue = await page
 					.getByRole( 'tabpanel', { name: 'Settings' } )
 					.getByLabel( 'Title attribute' )
@@ -1254,7 +1254,7 @@ test.describe( 'Block bindings', () => {
 					page
 						.getByRole( 'tabpanel', { name: 'Settings' } )
 						.getByLabel( 'Alternative text' )
-				).toBeDisabled();
+				).toHaveAttribute( 'readonly' );
 				const altValue = await page
 					.getByRole( 'tabpanel', { name: 'Settings' } )
 					.getByLabel( 'Alternative text' )