This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚛️ Hydrate the blocks with Directives Hydration (using
wp-block
andwp-inner-blocks
) #66⚛️ Hydrate the blocks with Directives Hydration (using
wp-block
andwp-inner-blocks
) #66Changes from 13 commits
aa164e1
88a73ab
64c8877
99635c4
087815b
81c6c56
4dc3cd2
e82e445
dae5bd4
c0fe8c4
abe0605
333368f
10fb30a
2a8737a
6b2e9f2
21a8f3f
adfb7ae
ec9574a
261b6de
b0c6ed7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need
.props.children
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because you run
hydrate
on the parent element (wp-site-blocks
), but you pass the vdom of the content (wp-site-blocks
works as a wrapper).We can change this with a better approach in the future. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see. I'm using createRootFragment for that 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a possibility that a node name is not in lowercase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the node is an Element, it always return the uppercase name (e.g.
DIV
for<div>
). 😅There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I was using
node.localName
🙂