Use NSURLSession to download files on iOS and update error returned on Android #15
Conversation
|
Wonderful! I'll take a more thorough look at the code in a sec, but... docs? :) |
|
|
||
| // Run async download task | ||
| File dir = file.getParentFile(); | ||
| if (dir != null && !(dir.mkdirs() || dir.isDirectory())) { |
There was a problem hiding this comment.
What if dir is null? Can getParentFile even return that?
There was a problem hiding this comment.
getParentFile can return null, I'll change that.
| @@ -256,10 +256,10 @@ - (void)deleteFiles:(CDVInvokedUrlCommand *)command { | |||
|
|
|||
| - (void)backgroundDelete:(CDVInvokedUrlCommand *)command { | |||
| @autoreleasepool { | |||
| NSMutableArray *uris = [[NSMutableArray alloc] initWithArray:command.arguments copyItems:YES]; | |||
| NSArray *uris = command.arguments; | |||
There was a problem hiding this comment.
I guess my assertion was correct that an NSArray would do just fine (compared to a resizable array). I didn't say anything about not copying the items though, but did you see an opportunity here that I missed? My only concern would be some weird multi threaded case (that you would be more suited to identify than me here), where not having a copy would create corrupted reads.
There was a problem hiding this comment.
Indeed, this was legacy code of deleting files when it was not yet done in the background. There should not be any weird multi threaded cases here.
|
Docs on errors would still be great :) |
|
Ah right! |
jrouault
force-pushed
the
task/NSURLSession
branch
2 times, most recently
from
101319a to
5647589
Compare
|
Updated |
| | 5 | `HTTP_REQUEST_CONTENT_ERROR` | Content received in HTTP request could not be read | | ||
| | 6 | `DIRECTORY_CREATION_ERROR` | Creation of the directory to save the asset failed | | ||
| | 7 | `FILE_CREATION_ERROR` | Saving the asset failed | | ||
| | 8 | `JSON_CREATION_ERROR` | Your call to WizAssets' method failed and its error could not be processed internally | |
There was a problem hiding this comment.
Hmm, I think from a JS point of view, getting that code as a string would be really useful. That's imho the more common paradigm in JS.
There was a problem hiding this comment.
As discussed, I use the same behaviour as the one on official Cordova plugins such as the File plugin. I added a quick explanation and an example how to have access to these constants.
|
LGTM 👍 |
jrouault
force-pushed
the
task/NSURLSession
branch
from
cbeaffa to
e2ef1c0
Compare
Major
downloadFilenow uses NSURLSession API to download files on iOS. If the HTTP request fails, it returns the HTTP code. Otherwise we return the samesuccessanswer. (iOS)downloadFileerrors returned have been updated on Android to match iOS behaviour (Android)poke @Tatsujinichi and @ronkorving