Add (void) to remove -Wstrict-prototypes warnings #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR introduces several spelling errors; please remove them. |
|
Dont know how those got in there, but they are fixed and I found another one as well |
evanmiller
reviewed
Sep 20, 2023
| @@ -366,7 +366,7 @@ void ieee2xpt(unsigned char *ieee, unsigned char *xport) { | |||
| shift = (int) | |||
| (ieee_exp = (int)(((ieee1 >> 16) & 0x7ff0) >> 4) - 1023) | |||
| & 3; | |||
| /* the ieee format has an implied "1" immdeiately to the left */ | |||
| /* the ieee format has an implied "1" immediately to the left */ | |||
There was a problem hiding this comment.
immediately is correct no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands on 5ad8004
Because just building Readstat on macos with XCode 14.3 leads to a whole lot more of those warnings and with this PR they should be silenced properly.