Skip to content
This repository has been archived by the owner on Jan 13, 2021. It is now read-only.

issue#226 fix #8

Merged
merged 3 commits into from
Jun 2, 2016
Merged

issue#226 fix #8

merged 3 commits into from
Jun 2, 2016

Conversation

kewlkiev
Copy link

This fix is for SNS alarms not being configured for each step and hence only final step's error messages are displayed in SNS alarms
coursera#226
@idralyuk @everanurag

@idralyuk
Copy link

idralyuk commented May 13, 2016

@kewlkiev, thank you.

Can you add a feature toggle for this?

Some users might not want to see the full cascade of failures.

@kewlkiev
Copy link
Author

@idralyuk have added feature toggle for cascade failures.
if YAML or config have
topic_arn configured and it starts with "all:" it will be enabled for all steps else only teardown step will consist of failure SNS configured.

so topic_arn will look like
topic_arn: '**all:**arn:aws:sns:us-west-2:XXXXXXXXXX:YYYYYYYYYY' for all steps having SNS configured and
topic_arn: 'arn:aws:sns:us-west-2:XXXXXXXXXX:YYYYYYYYYY'
for SNS only in teardown step

@kewlkiev
Copy link
Author

also @idralyuk @everanurag have added status in the subject itself, because otherwise lambda filtering was ignoring any onSuccess messages which were using same SNS object.
so that we can filter CASCADE_FAILED from the messages and at same time be able to not filter out success message because they don't have error trace.

@idralyuk
Copy link

idralyuk commented Jun 2, 2016

Awesome, thank you, @kewlkiev

@idralyuk idralyuk merged commit eedbdd8 into WiserSolutions:develop Jun 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants