Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditions for installing prometheus above version 2.0 #57

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

klatys
Copy link

@klatys klatys commented Nov 15, 2017

I added few simple additions for installing version 2.0 and above.

@klatys
Copy link
Author

klatys commented Nov 15, 2017

about the failing build - not sure but is it possible this relates to containerd/containerd#337 somehow? not sure this is my mistake really..

@brainstorm
Copy link

@William-Yeh it would be rad to have this change merged into this repo, I'm looking into deploying prometheus 2.x... @klatys, is the Go environment correctly setup when running this on your machine or test setup?:

https://travis-ci.org/William-Yeh/ansible-prometheus/builds/302412553#L6986

@klatys
Copy link
Author

klatys commented Nov 28, 2017

OK, so I added test for v2 deploy, but have struggled with testing git deploys. At current versions master is broken for some systems - see builds here is it a bad idea to exclude testing git deploy? @William-Yeh

@klatys
Copy link
Author

klatys commented Feb 20, 2018

Alternatively, the master version could be added as allow_failures
https://docs.travis-ci.com/user/customizing-the-build/#Rows-that-are-Allowed-to-Fail
@William-Yeh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants