Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

62 deprecate getiftversion in favor of iftversion #63

Merged
merged 2 commits into from
Aug 21, 2023
Merged

62 deprecate getiftversion in favor of iftversion #63

merged 2 commits into from
Aug 21, 2023

Conversation

cpaniaguam
Copy link
Member

#62

@cpaniaguam cpaniaguam linked an issue Aug 20, 2023 that may be closed by this pull request
Deprecate getiftversion in favor of IFTVERSION #62
Closed
@cpaniaguam cpaniaguam self-assigned this Aug 20, 2023
@cpaniaguam
Copy link
Member Author

After merging WilhelmusLab/IceFloeTracker.jl#332 CI should pass.

@cpaniaguam cpaniaguam requested a review from tdivoll August 20, 2023 04:40
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.88% 🎉

Comparison is base (bf573b4) 77.04% compared to head (f7832b4) 77.92%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   77.04%   77.92%   +0.88%     
==========================================
  Files           8        8              
  Lines         318      299      -19     
==========================================
- Hits          245      233      -12     
+ Misses         73       66       -7
Files Changed Coverage Δ
src/h5.jl 97.18% <100.00%> (+7.18%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tdivoll
tdivoll approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@tdivoll tdivoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, everything passes! And codecov is better now too.

tdivoll
tdivoll reviewed Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@tdivoll tdivoll left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add in the docstrings on L70. * `iftversion`: The current version of IceFloeTracker is loaded into the function automatically` ?

@tdivoll
Copy link
Collaborator

tdivoll commented Aug 21, 2023

I can update the docstring in h5,jl on PR #45 !

@cpaniaguam
Copy link
Member Author

I can update the docstring in h5,jl on PR #45 !

Thanks! I'll merge this PR then.

@cpaniaguam cpaniaguam merged commit 4ef5326 into main Aug 21, 2023
This was referenced Aug 23, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdivoll tdivoll tdivoll approved these changes

Assignees

@cpaniaguam cpaniaguam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate getiftversion in favor of IFTVERSION
2 participants
@cpaniaguam @tdivoll