Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

54 use getlatlon from ift #55

Merged
merged 3 commits into from
Aug 17, 2023
Merged

54 use getlatlon from ift #55

merged 3 commits into from
Aug 17, 2023

Conversation

cpaniaguam
Copy link
Member

Note: Before merging this PR, WilhelmusLab/IceFloeTracker.jl#328 needs to be merged and published.

#54

TODO: Before merging, merge #279 in IFT
@cpaniaguam cpaniaguam self-assigned this Aug 17, 2023
@cpaniaguam cpaniaguam linked an issue Aug 17, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15% ⚠️

Comparison is base (ed440ce) 77.18% compared to head (d3b136a) 77.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   77.18%   77.04%   -0.15%     
==========================================
  Files           8        8              
  Lines         320      318       -2     
==========================================
- Hits          247      245       -2     
  Misses         73       73              
Files Changed Coverage Δ
src/IFTPipeline.jl 100.00% <ø> (ø)
src/h5.jl 90.00% <ø> (-0.22%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpaniaguam cpaniaguam requested a review from tdivoll August 17, 2023 19:11
Copy link
Collaborator

@tdivoll tdivoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, we can address the issue with Folds in PR #45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use getlatlon from IFT
2 participants