Sc16is7x2 code quality #1100
Sc16is7x2 code quality #1100
Conversation
… code between classes. This makes the code easier to read and reduce calls between classes.
|
I originally merged this in, but it broke the RS485 comms. It wasn't obvious why, so I cherry picked a little of it (mostly docs) and applied some other changes on top of it (e.g. changing to CircularBuffer), so unfortunately we may have lost some fixes and improvements that you might have made. I'd love to not lose those, but it will require another pass at differencing the two and making sure that 485 remains working. |
|
OK. Sorry about that. I'll follow this up when I have time. |
|
It broke it at run time, which is why it got merged, then rolled back a few days later after both I and a customer lost comms with RS485 devices. Basically comms with any Modbus RTU device went sideways with bus timeouts |
Some minor changes for better code quality.