Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various updates #1095

Merged
merged 3 commits into from
Nov 30, 2024
Merged

various updates #1095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
502ee1c
don't start simulating temp until StartSimulation is called
ctacke Nov 30, 2024
7af2691
make Label control clickable
ctacke Nov 30, 2024
c3dcc6a
minor updates to Gnss
ctacke Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Source/Meadow.Foundation.Core/Simulation/SimulatedTemperatureSensor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ public SimulatedTemperatureSensor(
_temperature = initialTemperature;
_minTemperature = minimumTemperature;
_maxTemperature = maximumTemperature;

StartSimulation(behavior);
}

private void SimulationProc(object? o)
Expand Down Expand Up @@ -104,7 +102,7 @@ private void ReportTimerProc(object? o)
public Units.Temperature? Temperature
{
get => _temperature;
private set
set
{
if (value == Temperature) return;

Expand Down
2 changes: 1 addition & 1 deletion .../Meadow.Foundation.Libraries_and_Frameworks/Graphics.MicroLayout/Driver/Controls/Label.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
/// <summary>
/// Represents a label display control in the user interface.
/// </summary>
public class Label : ThemedControl
public class Label : ClickableControl
{
private static Color DefaultTextColor = Color.White;
private static Color DefaultBackColor = Color.Transparent;
Expand Down
6 changes: 6 additions & 0 deletions ...undation.Libraries_and_Frameworks/Sensors.Location.Gnss.NmeaProcessor/Driver/Constants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
namespace Meadow.Foundation.Sensors.Location.Gnss;

internal static class Constants
{
public const string LogGroup = "nmea processor";
}
6 changes: 5 additions & 1 deletion ...ndation.Libraries_and_Frameworks/Sensors.Location.Gnss.NmeaProcessor/Driver/RmcDecoder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@ public string Name
/// <param name="sentence">The sentence</param>
public void Process(string sentence)
{
Process(NmeaSentence.From(sentence));
if (NmeaSentence.TryParse(sentence, out var s))
{
Resolver.Log.Debug($"Failure parsing {sentence}", Constants.LogGroup);
Process(NmeaSentence.From(sentence));
}
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion Source/Meadow.Foundation.Peripherals/Sensors.Gnss.NeoM8/Driver/NeoM8.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public partial class NeoM8 : IGnssSensor, IDisposable
/// <summary>
/// Raised when GNSS data is received
/// </summary>
public event EventHandler<IGnssResult> GnssDataReceived = default!;
public event EventHandler<IGnssResult>? GnssDataReceived = null;

/// <summary>
/// Supported GNSS result types
Expand Down
Loading