-
-
Notifications
You must be signed in to change notification settings - Fork 76
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #936 from WildMeOrg/NFRupdate
Update PR template to include NFRs
- Loading branch information
Showing
1 changed file
with
7 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,10 @@ | ||
[Plain-text summary description of the solution] | ||
[Plain-text summary description of the solution. Include any class updates, new or edited functions, significant changes to UX, etc] | ||
|
||
PR fixes #[REPLACE WITH ISSUE NUMBER] | ||
|
||
**Changes** | ||
- [bullet list include any model updates] | ||
- [new or edited functions] | ||
- [significant changes to UX] | ||
- [design decisions, especially if architectural patterns are new/altered] | ||
- [can use text, screenshots, or files] | ||
- [a callout of any ##TODO or ##FIXMEs found/created as part of the fix] | ||
**Before you Submit!** | ||
* Is all the text internationalized? | ||
* If you made a change to the header, did you update the react, jsp, and html? | ||
* Are all depedencies at a locked version? | ||
* Did you adhere to [best practices](https://wildbook.docs.wildme.org/contribute/code-guide.html)? | ||
* Is there a quick [unit test](https://wildbook.docs.wildme.org/contribute/tests.html) you can add? |