Merge pull request #709 from WildGums/GitHubSync/20241128-225011

GitHubSync update
WildGums · Nov 28, 2024 · 5a518c8 · 5a518c8
2 parents 4697a35 + f4af10b
commit 5a518c8
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/deployment/cake/lib-signing.cake b/deployment/cake/lib-signing.cake
@@ -49,7 +49,13 @@ public static void SignFilesInDirectory(BuildContext buildContext, string direct
     var codeSignContext = buildContext.General.CodeSign;
     var azureCodeSignContext = buildContext.General.AzureCodeSign;
 
-    var certificateSubjectName = buildContext.General.CodeSign.CertificateSubjectName;
+    if (buildContext.General.IsLocalBuild ||
+        buildContext.General.IsCiBuild)
+    {
+        // Never code-sign local or ci builds
+        return;
+    }
+
     if (!codeSignContext.IsAvailable &&
         !azureCodeSignContext.IsAvailable)
     {
@@ -259,6 +265,13 @@ public static void SignNuGetPackage(BuildContext buildContext, string fileName)
         return;
     }
 
+    if (!codeSignContext.IsAvailable &&
+        !azureCodeSignContext.IsAvailable)
+    {
+        buildContext.CakeContext.Information("Skipping code signing because none of the options is available");
+        return;
+    }
+
     buildContext.CakeContext.Information($"Signing NuGet package '{fileName}'");
 
     if (azureCodeSignContext.IsAvailable)