Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHubSync update #849

Merged
merged 1 commit into from
Nov 28, 2024
Merged

GitHubSync update #849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion deployment/cake/lib-signing.cake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,13 @@ public static void SignFilesInDirectory(BuildContext buildContext, string direct
var codeSignContext = buildContext.General.CodeSign;
var azureCodeSignContext = buildContext.General.AzureCodeSign;

var certificateSubjectName = buildContext.General.CodeSign.CertificateSubjectName;
if (buildContext.General.IsLocalBuild ||
buildContext.General.IsCiBuild)
{
// Never code-sign local or ci builds
return;
}

if (!codeSignContext.IsAvailable &&
!azureCodeSignContext.IsAvailable)
{
Expand Down Expand Up @@ -259,6 +265,13 @@ public static void SignNuGetPackage(BuildContext buildContext, string fileName)
return;
}

if (!codeSignContext.IsAvailable &&
!azureCodeSignContext.IsAvailable)
{
buildContext.CakeContext.Information("Skipping code signing because none of the options is available");
return;
}

buildContext.CakeContext.Information($"Signing NuGet package '{fileName}'");

if (azureCodeSignContext.IsAvailable)
Expand Down