Feature/orcomp 644 #278
Feature/orcomp 644 #278
Conversation
|
I think we should consider using System.CommandLine instead? |
| { | ||
| using Catel.Data; | ||
|
|
||
| public interface IResult : IContext |
There was a problem hiding this comment.
one of the points of the issue is to split IContext into IResult and ICommandLineParsingContext
it means IResult should not be inherited from IContext
I would extract two different interfaces from IContext: ICommandLineParsingContext and something like ICommandLineParsingResult and do something like that:
[ObsoleteEx]
public interface IContext : ICommandLineParsingContext, ICommandLineParsingResult
{
// put obsolete props and methods here
}
public interface IValidatedResult : ICommandLineParsingResult
{
IValidationContext ValidationContext { get; }
}
| { | ||
| using Catel.Data; | ||
|
|
||
| public interface IValidatedResult : IContext |
There was a problem hiding this comment.
read the comments for the IResult
|
|
||
| public List<char> QuoteSplitCharacters { get; set; } | ||
|
|
||
| public void Finish() |
| using System; | ||
| using System.Reflection; | ||
|
|
||
| internal static class PropertyHelper |
There was a problem hiding this comment.
rename the class to ObjectExtensions
good point |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description of Change
As noted by @mkhomutov , in the current implementation, the context is actually not really the context.
It should be a returning value of Parse() method.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral Changes
None
Testing Procedure
PR Checklist