Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC support & Flask 2.3+ fix #35

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Add OIDC support & Flask 2.3+ fix #35

merged 3 commits into from
Jun 25, 2024

Conversation

burritosoftware
Copy link
Member

Adds OpenID Connect support and fixes an issue with the server not running on Flask 2.3+ due to the deprecation of @app.before_first_request, see https://stackoverflow.com/questions/73570041/flask-deprecated-before-first-request-how-to-update.

Needs Black formatter to be run.

@burritosoftware burritosoftware added the enhancement New feature or request label Jun 25, 2024
Copy link
Member

@oscie57 oscie57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though please refer to the unauthorised handler

food.py Outdated Show resolved Hide resolved
thepantry/admin.py Show resolved Hide resolved
@burritosoftware
Copy link
Member Author

Running black to resolve, then will squash and merge

@burritosoftware
Copy link
Member Author

Need check bypass from @noahpistilli, if you could check the black formatted files commit, and then turn off Required statuses/checks in the repo settings, thanks

@noahpistilli noahpistilli merged commit c407e44 into WiiLink24:master Jun 25, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants