info messages to firewall #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also make the script be called by path, so easier to test by placing script at /usr/local/bin
adrelanos
reviewed
Sep 26, 2022
adrelanos
reviewed
Sep 26, 2022
adrelanos
reviewed
Sep 26, 2022
adrelanos
reviewed
Sep 26, 2022
adrelanos
reviewed
Sep 26, 2022
|
all changes done |
adrelanos
reviewed
Sep 26, 2022
| @@ -365,6 +373,7 @@ ipv4_output() { | |||
| ## https://phabricator.whonix.org/T533#11025 | |||
| if [ "$firewall_mode" = "timesync-fail-closed" ]; then | |||
| local socks_port_item | |||
| [ "${info_enabled}" = "1" ] && output_cmd "INFO: not opening Internal TCP ports ${INTERNAL_OPEN_PORTS}, except 9108 for sdwdate, because firewall_mode=$firewall_mode" | |||
There was a problem hiding this comment.
Actually I think this is useful. So useful that I'll drop "${info_enabled}" = "1" after merge. That is because firewall mode timesync-fail-closed will be a challenge usability wise anyhow. Therefore this messages seems helpful and not too verbose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forums.whonix.org/t/print-ports-opened-in-the-firewall/15469/4
the gateway message is more complete
for the workstation, I didn't know what to put, so only EXTERNAL and INTERNAL ports were mentioned.
I didn't find where it is opening INTERNAL_OPEN_PORTS, so this message is not printed.