feat(pool_manager): pools query improvement #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerber0x
requested review from
0xFable,
kaimen-sano,
Sen-Com and
nseguias
as code owners
kerber0x
force-pushed
the
feat/pools-query
branch
from
1a6462c to
4d7f83e
Compare
kerber0x
changed the base branch from
release/v2_contracts
to
feat/integration-tests-crate
kerber0x
force-pushed
the
feat/pools-query
branch
from
edb84a7 to
fdc26a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
This PR modifies the
Poolquery on the pool manager so that it returns a list of pools if desired. This can help frontends list all the pools in the contract. It offers pagination.Related Issues
Checklist:
Update index.md)cargo fmt --all --.cargo clippy -- -D warnings.cargo schema.