-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: bonding manager #352
refactor: bonding manager #352
Conversation
This is turning to be an overhaul of the bonding manager, not just removing a single msg 😅 |
b499cac
to
394de43
Compare
e61863f
to
395b00d
Compare
395b00d
to
c19ef89
Compare
Schema generation had missing jobs:
Please run |
1 similar comment
Schema generation had missing jobs:
Please run |
1dcbd7b
to
e3336f5
Compare
662c1e2
to
0a2b551
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v2_contracts #352 +/- ##
========================================================
+ Coverage 90.09% 91.15% +1.05%
========================================================
Files 278 279 +1
Lines 29604 31113 +1509
========================================================
+ Hits 26673 28361 +1688
+ Misses 2931 2752 -179 ☔ View full report in Codecov by Sentry. |
Schema generation had missing jobs:
Please run |
23586f6
to
1c9120d
Compare
1c9120d
to
6df2793
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, massive work here ser! Changes look good see you put in a shift reorganising some things too thats very much appreciated will make future features easier to get in.
A couple comments but overall looks class and want to see him merged
🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Made some comments to improve the code and some questions to make sure I understand things right. Awesome work! Love seeing some convoluted tests. Once we're done we should write a big test that tries every part of the code ⭐
contracts/liquidity_hub/bonding-manager/src/bonding/commands.rs
Outdated
Show resolved
Hide resolved
1ac4516
to
2bee41f
Compare
Description and Motivation
This PR refactors the bonding manager, fixing a couple of issues with the bonding and claiming mechanisms. It also refactors the state, using an
IndexedMap
to hold both bonds and unbonds operations by a user.Related Issues
Checklist:
Update index.md
)cargo fmt --all --
.cargo clippy -- -D warnings
.cargo schema
.