Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smart-contracts): remove balances from PairInfo & fix minor errors #321

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

nseguias
Copy link
Contributor

@nseguias nseguias commented Apr 8, 2024

Description and Motivation

This PR removes balances from PairInfo, as it doesn't provide any value. The balances are being held in assets already.

The previous branch, release/v2_contracts, had a couple of errors that were shown at compile time that are now fixed.

It also fixes the pool-manager tests that were not passing.

Related Issues

#307


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (b3cde00) to head (f1fdf5b).
Report is 3 commits behind head on release/v2_contracts.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           release/v2_contracts     #321      +/-   ##
========================================================
- Coverage                 88.50%   88.50%   -0.01%     
========================================================
  Files                       252      252              
  Lines                     23604    23602       -2     
========================================================
- Hits                      20890    20888       -2     
  Misses                     2714     2714              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@0xFable 0xFable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but remove file build_rs_cov.profraw unless we need it

@nseguias nseguias merged commit 1ae8097 into release/v2_contracts Apr 8, 2024
5 of 6 checks passed
@nseguias nseguias deleted the fix/remove-balances-from-pairinfo branch April 8, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants