Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle libgstlibav & deps #7

Merged
merged 1 commit into from
May 17, 2024

Conversation

IsaacMarovitz
Copy link
Member

@IsaacMarovitz IsaacMarovitz commented May 17, 2024

Superceeds #4.

@IsaacMarovitz IsaacMarovitz requested a review from Gcenx May 17, 2024 19:05
@101arrowz
Copy link

I will point out that when I tried this on CrossOver Wine, it caused Steam to launch much more slowly for me than my change, and additionally this does not support hardware acceleration. If you're doing this though, might as well remove libgstapplemedia too.

@101arrowz
Copy link

If you're having issues with locating and bundling dependencies, I'd suggest taking a look at what I did here, which works quite well and operates recursively so it doesn't miss anything. (I actually managed to make it work without installing Homebrew at all by simply fetching the bottles and patching them like Homebrew does, but that's probably not necessary given that you're using GH actions for builds.)

@Gcenx
Copy link

Gcenx commented May 17, 2024

@IsaacMarovitz id recommend working on this offline so save yourself a headache with actions.

@IsaacMarovitz IsaacMarovitz merged commit 78a92b2 into Whisky-App:7.7 May 17, 2024
1 check passed
@IsaacMarovitz IsaacMarovitz deleted the libgstlibav branch May 17, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants