Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added Yakuza Kiwami 2 #119

Merged
merged 1 commit into from
Nov 7, 2024
Merged

docs: added Yakuza Kiwami 2 #119

merged 1 commit into from
Nov 7, 2024

Conversation

Anomamu
Copy link
Contributor

@Anomamu Anomamu commented Nov 2, 2024

Description

Type(s)

  • Game page addition
  • Game page modification
  • Other wiki edit

Verification

Have you

  • Followed the contribution guidelines?
  • Ran ./scripts/generate.mjs?
  • Ran ./scripts/lint.mjs?
  • Checked spelling and grammar?
  • (If applicable) Provided documentation for a game not working? (i.e. detailing what happens when the game doesn't work?)
  • (If applicable) Ensured the linked Steam ID is the correct one for your game addition?

@mattmaniak
Copy link
Member

Check and fill the "Verification. Have you" section in your PR template. Checkboxes are missing.

src/SUMMARY.md Outdated Show resolved Hide resolved
@hahayupgit hahayupgit added the game addition New game addition to the docs label Nov 7, 2024
@hahayupgit
Copy link
Member

@Anomamu I've gone in and fixed your PR, in the future please make sure to run ./scripts/generate.mjs and ./scripts/lint.mjs before merging your PRs to catch any errors. You had swapped the review metadata and game embed tags.

@hahayupgit hahayupgit requested a review from mattmaniak November 7, 2024 04:07
Copy link
Member

@mattmaniak mattmaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that I missed something before... @hahayupgit
Now it's all good.

@mattmaniak mattmaniak merged commit cf567fc into Whisky-App:main Nov 7, 2024
1 check passed
@hahayupgit
Copy link
Member

It seems that I missed something before... @hahayupgit Now it's all good.

It was just linting stuff, you would''ve caught it when you ran the checks 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
game addition New game addition to the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants