Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GTA SA and Genshin Impact links #106

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

mattmaniak
Copy link
Member

Fix links that are wrongly formatted (Genshin) and broken (GTA SA Steam). I approved and merged those PRs with those issues. I missed them basically.

@mattmaniak mattmaniak requested a review from hahayupgit October 9, 2024 21:02
@JoshuaBrest
Copy link
Contributor

Genshi should also have a note with a ban disclaimer.

@mattmaniak
Copy link
Member Author

mattmaniak commented Oct 10, 2024

@JoshuaBrest This ban disclaimer should be regarding what? I mean in which point this Genshin setup may be risky. I didn't play the game so that is why I am asking.

@JoshuaBrest
Copy link
Contributor

@JoshuaBrest This ban disclaimer should be regarding what? I mean in which point this Genshin setup may be risky. I didn't play the game so that is why I am asking.

Genshin Impact. In the past, they have had ban waves that affected Whisky users.

@mattmaniak
Copy link
Member Author

@JoshuaBrest This ban disclaimer should be regarding what? I mean in which point this Genshin setup may be risky. I didn't play the game so that is why I am asking.

Genshin Impact. In the past, they have had ban waves that affected Whisky users.

Is there any link to such issue? Just to document it there.

@JoshuaBrest
Copy link
Contributor

@JoshuaBrest This ban disclaimer should be regarding what? I mean in which point this Genshin setup may be risky. I didn't play the game so that is why I am asking.

Genshin Impact. In the past, they have had ban waves that affected Whisky users.

Is there any link to such issue? Just to document it there.

https://discord.com/channels/1115955071549702235/1232559655113457694/1232559655113457694

Copy link
Member

@hahayupgit hahayupgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will add the Genshin warning in a separate PR

@hahayupgit hahayupgit merged commit 6eb9b89 into Whisky-App:main Oct 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants