Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add menu bar #571

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add menu bar #571

wants to merge 2 commits into from

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Oct 29, 2023

I think it would be really nice to add a menu bar so that we can close the Whisky window and still have its applications running or access certain useful tools.

I have created this POC for your consideration. Changes include

  1. Closing window no longer terminates the application
  2. Can perform some common commands right from the menu bar without having the application in focus
  3. Uses pure vanilla SwiftUI components
Screenshot 2023-11-03 at 1 27 15 AM

@IsaacMarovitz
Copy link
Member

I like the concept! Looks like it could be helpful

@cuba
Copy link
Contributor Author

cuba commented Oct 29, 2023

I like the concept! Looks like it could be helpful

Glad you like the concept! I can develop it further if you think it's worthwhile. I don't think it should become too bloated because it should just perform some of the most common functionality. But feel free to put any comments or suggestions in code or here where you would like to see this go, the file organization, etc when you can.

So if we're in agreement, I'd like to take this further I'll have to touch some more of your written code just so the menu bar and the application stays in sync because I don't think they do right now.

@cuba cuba force-pushed the uplift/menu-toolbar branch 2 times, most recently from faf541d to ee5cf38 Compare November 1, 2023 05:15
@IsaacMarovitz
Copy link
Member

@cuba Rebase needed after recent reorganisation

@cuba cuba force-pushed the uplift/menu-toolbar branch from ee5cf38 to 79ba9e3 Compare November 3, 2023 07:26
@cuba
Copy link
Contributor Author

cuba commented Nov 3, 2023

@cuba Rebase needed after recent reorganisation

Done, I had to rebase it on my newer settings fixes PR so that the changes in the menu bar / in the app are in sync. Added icons to pinned items as well

@cuba cuba changed the title [POC] Add menu bar Add menu bar Nov 3, 2023
@cuba cuba force-pushed the uplift/menu-toolbar branch 2 times, most recently from 8a09e71 to c658094 Compare November 10, 2023 06:41
@cuba cuba force-pushed the uplift/menu-toolbar branch from c658094 to b4a7694 Compare November 23, 2023 05:10
@cuba cuba force-pushed the uplift/menu-toolbar branch from b4a7694 to 4304725 Compare November 27, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants