Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debug build bundle identifiers #566

Closed
wants to merge 1 commit into from

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Oct 28, 2023

Set different bundle ids for debug builds. This allows isolation from release installs of the application.

@IsaacMarovitz
Copy link
Member

I don't think this is a good idea, as we use the Bundle Identifier to name and find dependencies and such

@cuba
Copy link
Contributor Author

cuba commented Oct 28, 2023

I don't think this is a good idea, as we use the Bundle Identifier to name and find dependencies and such

I think you know better than me, so feel free to close this issue if you feel the risk is too high.

But if you're talking about these things:

public static let libraryFolder = FileManager.default.urls(for: .applicationSupportDirectory,
                                                               in: .userDomainMask)[0]
        .appending(path: Bundle.main.bundleIdentifier ?? "com.isaacmarovitz.Whisky")
        .appending(path: "Libraries")

They use Bundle.main.bundleIdentifier which will pull the correct bundle ID.

The coalescence at the end (?? "com.isaacmarovitz.Whisky") won't trigger but I can also add some precompile macros for those as a precaution.

but yah it could create a bit more confusion when discussing instructions for people that chose to build the debug build from source. I have these changes locally so I don't mess up my release configurations as I use the app myself.

@cuba cuba force-pushed the uplift/debug-builds branch from c5e3d24 to 2c59b5c Compare October 28, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants