WhiskyCmd: fix the run command #1264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: #1088
FIX: #1140
Fix two issues related to the
runcommand:program.runInTerminalwould launch AppleScript asynchronously via a coroutine, but the main process had already exited, preventing it from starting. AddedRunLoop.main.run()to make the main process wait until the execution is completed.program.runInTerminal, double quotes in the environment variables withinwineCmdneed to be escaped again.PS: Sometimes, when the Whisky main UI runs for an extended period, it causes High CPU usage. To restore normal operation, the Whisky application itself needs to be closed (without closing the Wine-launched Windows application). The cause has not yet been identified.