Draft: Adding ability for vcdi presentation proof #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nicwisd1/aries-cloudagent-python into feat/vcdi-implementation
Signed-off-by: Orjiene Kenechukwu <[email protected]>
supersonicwisd1
changed the title
gvelez17
reviewed
Mar 8, 2024
| @@ -54,6 +54,13 @@ class Format(Enum): | |||
| ".formats.dif.handler.DIFPresFormatHandler" | |||
| ), | |||
| ) | |||
| VCDI = FormatSpec( | |||
| "dif/", | |||
There was a problem hiding this comment.
are we sure this should be identical to DIF above? if they are identical then why do we have separate one?
There was a problem hiding this comment.
For presentation we are using the DIF Presentation Exchange from https://github.com/hyperledger/aries-rfcs/blob/main/features/0510-dif-pres-exch-attach/README.md. I was following the attachment format.
gvelez17
reviewed
Mar 8, 2024
| @@ -127,6 +127,11 @@ class V20PresProposalByFormatSchema(OpenAPISchema): | |||
| required=False, | |||
| metadata={"description": "Presentation proposal for DIF"}, | |||
| ) | |||
| vc_di = fields.Nested( | |||
| DIFProofProposalSchema, | |||
There was a problem hiding this comment.
I didn't want to write another proposal schema since DIFProofProposalSchema already exist to avoid redundancy
There was a problem hiding this comment.
gvelez17
reviewed
Mar 14, 2024
| }, | ||
| PRES_20: { | ||
| V20PresFormat.Format.INDY.api: "hlindy/[email protected]", | ||
| V20PresFormat.Format.DIF.api: "dif/presentation-exchange/[email protected]", | ||
| V20PresFormat.Format.VCDI.api: "dif/presentation-exchange/[email protected]" |
There was a problem hiding this comment.
@supersonicwisd1 do we still need this, do you want to do a fresh PR into clean-base with the needed things?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.