Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue 85 - Declaration of WendellAdriel\ValidatedDTO\SimpleDTO… #86

Merged

Conversation

patriziotomato
Copy link
Contributor

Fixes this error in case that you use your DTO in context of Laravel using Jsonable interface.

Declaration of WendellAdriel\ValidatedDTO\SimpleDTO::toJson(): string must be compatible with Illuminate\Contracts\Support\Jsonable::toJson($options = 0)

…::toJson(): string must be compatible with Illuminate\Contracts\Support\Jsonable::toJson($options = 0) WendellAdriel#85
Copy link
Owner

@WendellAdriel WendellAdriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice catch!
Thanks for the contribution! 💪

@WendellAdriel WendellAdriel merged commit cb418e0 into WendellAdriel:main Sep 20, 2024
8 checks passed
@patriziotomato patriziotomato deleted the issue-85-declaration-toJson branch September 20, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants