fix:Fix static property data bleed in RulesValidation

[BadJacky]

Resolve issue where static properties in RulesValidation Trait are shared across multiple classes, causing data bleeding. Added reset method for static properties.

When using the RulesValidation Trait, static properties such as *ValidationRules and *ValidationMessages are shared across multiple classes. This can lead to data bleeding, especially when a Model inherits from another Model that uses the Lift Trait and multiple database save operations are triggered in the same request.

Solution

To resolve this issue, the resetValidations method has been added to the RulesValidation Trait. This method resets the static properties to their initial state before each operation, preventing data bleeding between different Model instances.

Changes

• Added resetValidations method to the RulesValidation Trait.
• Updated all relevant Model calls to invoke resetValidations where necessary to ensure data integrity.

This pull request includes changes to improve the consistency and maintainability of the codebase by replacing self with static in various methods and adding a new method to reset validation messages.

Improvements to method calls:

• src/Lift.php: Replaced all instances of self with static in the bootLift, syncOriginal, ignoredProperties, and fillProperties methods to ensure proper method resolution in subclasses. [1] [2] [3] [4] [5] [6]

New functionality:

• src/Concerns/RulesValidation.php: Added a new method resetValidations to reset validation messages and rules.

This refactoring enhances the flexibility and reusability of the code by allowing subclasses to override static methods more effectively.

[WendellAdriel]

Hey @BadJacky thanks for the contribution, but I have a question

What's the data bleed issue here? I'm asking because the static properties related to rules should be shared to avoid the need to build them every time, this was done in order to improve the performance.

Can you show me where and how the data bleed is happening?
Also, can you add some benchmarks before and after this change to understand the impact in the performance?
Because I'm really worried that doing this reset on every action will have impact when doing a lot of DB actions.

[BadJacky]

Hey @BadJacky thanks for the contribution, but I have a question

What's the data bleed issue here? I'm asking because the static properties related to rules should be shared to avoid the need to build them every time, this was done in order to improve the performance.

Can you show me where and how the data bleed is happening? Also, can you add some benchmarks before and after this change to understand the impact in the performance? Because I'm really worried that doing this reset on every action will have impact when doing a lot of DB actions.

I have multiple Model files, all of which inherit from my custom BaseModel. I'm using a "Lift Trait" in BaseModel. When I trigger the saving of multiple models within a single request, the validation data retrieved during the second save still contains the data from the first save. To address this, I've implemented a reset method to reset the data.

[BadJacky]

Hi @WendellAdriel ，
I have utilized Pest to debug this bug and have identified a reproducible method. I will provide the corresponding code and a test report for your review. If you have time, please take a look.
The BaseModel

The Book Model

The PostTimestamp Model

The Lift Trait with debug

The Test script

The TestCase output :

I have provider the files I used, you can get details from the files
code.zip

[BadJacky]

@WendellAdriel
I would like to ask if you have time to take a look?