Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Change FPDF package" #6

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Revert "Change FPDF package" #6

merged 1 commit into from
Jul 23, 2020

Conversation

maddhatter
Copy link
Contributor

@maddhatter maddhatter commented Jun 4, 2018 •
edited
Loading

Reverting to the abandoned itbz package (undo #4)

Revert "Change FPDF package"
d3c8448 
This reverts commit 38f145c.
@b-enoit-be
Copy link

@maddhatter @Webklex
This PR should be merged in, as it stands the lib was broken because of this (see also issue #7).
If this PR is not merged, another possible (and maybe better) fix would be to change the use statement from

laravel-pdfmerger/src/PDFMerger/PDFMerger.php

Line 15 in 459f8a6

use fpdi\FPDI;
to read

use setasign\Fpdi\Fpdi;

As this is documented in FPDI library

@ammarax ammarax mentioned this pull request Oct 2, 2019
Closed
@jorisatabix
Copy link

ping

@Webklex Webklex merged commit 55ad017 into Webklex:master Jul 23, 2020
@aldiazhar aldiazhar mentioned this pull request Jul 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maddhatter @b-enoit-be @jorisatabix @Webklex