Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenCDMi] Remove all unnecessary member variables to save some memory #329

Merged
merged 3 commits into from
Nov 21, 2024
Merged

[OpenCDMi] Remove all unnecessary member variables to save some memory #329

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74a7e40
Use the warning supression instead of the variable is not used macro
VeithMetro Nov 20, 2024
f7d6f91
Formatting changes
VeithMetro Nov 20, 2024
34e0dc3
Remove all unused member variables
VeithMetro Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions OpenCDMi/FrameworkRPC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,9 +286,6 @@ namespace Plugin {
: Exchange::DataExchange(name, defaultSize)
, Core::Thread(Core::Thread::DefaultStackSize(), _T("DRMSessionThread"))
, _mediaKeys(mediaKeys)
, _mediaKeysExt(dynamic_cast<CDMi::IMediaKeySessionExt*>(mediaKeys))
, _sessionKey(nullptr)
, _sessionKeyLength(0)
{
Core::Thread::Run();
TRACE(Trace::Information, (_T("Constructing buffer server side: %p - %s"), this, name.c_str()));
Expand Down Expand Up @@ -375,9 +372,6 @@ namespace Plugin {

private:
CDMi::IMediaKeySession* _mediaKeys;
VARIABLE_IS_NOT_USED CDMi::IMediaKeySessionExt* _mediaKeysExt;
VARIABLE_IS_NOT_USED uint8_t* _sessionKey;
VARIABLE_IS_NOT_USED uint32_t _sessionKeyLength;
};

// IMediaKeys defines the MediaKeys interface.
Expand Down Expand Up @@ -495,7 +489,6 @@ PUSH_WARNING(DISABLE_WARNING_THIS_IN_MEMBER_INITIALIZER_LIST)
Exchange::ISession::ICallback* callback,
const CommonEncryptionData* sessionData)
: _parent(*parent)
, _refCount(1)
, _keySystem(keySystem)
, _sessionId(mediaKeySession->GetSessionId())
, _mediaKeySession(mediaKeySession)
Expand All @@ -520,7 +513,6 @@ PUSH_WARNING(DISABLE_WARNING_THIS_IN_MEMBER_INITIALIZER_LIST)
Exchange::ISession::ICallback* callback,
const CommonEncryptionData* sessionData)
: _parent(*parent)
, _refCount(1)
, _keySystem(keySystem)
, _sessionId("")
, _mediaKeySession(dynamic_cast<CDMi::IMediaKeySession*>(mediaKeySession))
Expand Down Expand Up @@ -748,7 +740,6 @@ POP_WARNING()
private:
AccessorOCDM& _parent;
mutable Core::CriticalSection _adminLock;
VARIABLE_IS_NOT_USED mutable uint32_t _refCount;
std::string _keySystem;
std::string _sessionId;
CDMi::IMediaKeySession* _mediaKeySession;
Expand Down
Loading